Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian text in epub not breaking correctly #1118

Open
kjk opened this Issue Jan 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@kjk
Copy link
Member

kjk commented Jan 7, 2019

Test file: Morgan_Stal-ostaetsya.epub

Looks like 158b13c to improve CJK breaking made Russian breaking worse (it worked in 3.1.2).

Also, the same change seems to have created an infinite loop in Eloquent_JavaScript.mobi

@ultranity

This comment has been minimized.

Copy link
Contributor

ultranity commented Feb 17, 2019

sorry for my carelessness. Though I can't reproduce the infinite loop in Eloquent_JavaScript.mobi when debugging, the problem should be both fixed by #1130, pls check if it works

kjk added a commit that referenced this issue Feb 17, 2019

bug fix for #1118 and158b13c (#1130)
* no longer crash when lenThatFits == 0

* try to prevent break in CJK sentence

try to prevent  break in CJK sentence, and some minor adjustments to the reparse logic.

* tweak lenThatFits  

get lenThatFits suits  (pageDx  -  currX)  instead of (pageDx - NewLineX())
and some other corresponding corrections

* add lentmp

* Revert "Merge branch 'master' into pr/2"

This reverts commit caf0697, reversing
changes made to 21c252e.

* Revert "Revert "Merge branch 'master' into pr/2""

This reverts commit 07191b3.

* Revert "Revert "Revert "Merge branch 'master' into pr/2"""

This reverts commit 85c2f51.

* Update HtmlFormatter.cpp

bug fix for  158b13c

* limit windows min width dynamically

limit windows min width to prevent render loop when siderbar is too big

* Revert "limit windows min width dynamically"

This reverts commit a5c4a26.

* Update HtmlFormatter.cpp

* Revert "Revert "limit windows min width dynamically""

This reverts commit f1abbed.

3ToThe6 added a commit to 3ToThe6/sumatrapdf that referenced this issue Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.