Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab appearance #343

Open
7ko opened this Issue Nov 2, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@7ko
Copy link

7ko commented Nov 2, 2015

When two tabs are opened it is a bit hard to tell which one is active:

pdf-clipboard02

Please consider how it is easy to tell it in the other program:

pdf-clipboard03

@patricktokeeffe

This comment has been minimized.

Copy link

patricktokeeffe commented Nov 2, 2015

SumatraPDF makes the active tab darker than inactive tabs, which is backwards w.r.t to every other tabbed program in existence I've used. I disable the tabs feature because this issue is so distracting and counter-intuitive (and I'm here today because I had to re-disable them).

The solution: make inactive tabs shaded (darker) to indicate they are in the background. Consider this screenshot... which Firefox tab is active? which SumatraPDF tab is active? Which of those questions required less thought?

sumatrapdf tab problem screenshot

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Nov 9, 2015

SumatraPDF makes the active tab darker than inactive tabs

@patricktokeeffe: No it doesn't, not for me at least (tested with 32-bit 3.1 and 3.1.1 after updating just now on Windows 7).

tabs

@patricktokeeffe

This comment has been minimized.

Copy link

patricktokeeffe commented Nov 13, 2015

That's interesting @SumatraPeter. Here's a screenshot of SumatraPDF 3.1.1-x64-portable running on Windows 7 Enterprise SP1 x64:

sumatra-3 1 1-win7x64-screenshot

Active tab is darker. So... maybe it's x86 vs x64? @7ko what is your environment?

@7ko

This comment has been minimized.

Copy link
Author

7ko commented Nov 13, 2015

I did a clean install and nothing changed - see the first post, active tab is lighter and after I saw your samples I see the outlines are missing on mine. Is this windows theme-dependent?
PS I have Win 10 x86

@7ko

This comment has been minimized.

Copy link
Author

7ko commented Nov 13, 2015

I think what makes other programs like Firefox, Edge, etc seem more intuitive is that the tab look like a vertical extension of the underlying UI element (i.e. of a toolbar) . On the other hand, in Sumatra tabs seem to float on top, it doesn't help regardless of which is darker or lighter. I like the visual solution they employed in Firefox, the tabs not only have rounded top corner, but also on the lower part they "blend" into a toolbar with a kind of "skirts".

@SumatraPeter

This comment has been minimized.

Copy link

SumatraPeter commented Nov 21, 2015

So... maybe it's x86 vs x64?

Doesn't seem to be the case.

Is this windows theme-dependent?

I think you nailed it.

Windows 7 Ultimate x64 with _Aero_ theme: Active tab is lighter

win7_aero

Windows 7 Ultimate x64 with _Aero Basic_ theme: Active tab is lighter

win7_basic

Windows 7 Ultimate x64 with _Aero Classic_ theme: Active tab is darker

win7_classic

In my previous screenshot on Windows 7 x86 I was using Aero Basic, and @patricktokeeffe seems to be using Aero Classic on Windows 7 x64. The theme being used by @7ko in Windows 10 x86 is not known, so active tab highlighting under the Windows Classic theme needs to be fixed (colors reversed), and perhaps in Windows 10 as well.

@ofaurax

This comment has been minimized.

Copy link

ofaurax commented Feb 2, 2017

Hello! I'm currently working on this, please have a look at #559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.