fix widget repeat rendering #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If pop is used to get the value of 'summernote' on self.attrs, then the html returned by render() may change after the first call. For example:
```python
w=SummernoteWidget(attrs={'summernote':{'height':'123px'}})
w.render('test','',attrs={'id':'test'})
```
Will render the iframe height as '123px', however a second call
```python
w.render('test','',attrs={'id':'test'})
```
will render whatever the default value for height is instead of '123px' because the summernote value of attrs was popped in the first call and therefore is no longer available for subsequent calls.
This PR fixes that by chaning the self.attrs.pop('summernote', {}) calls in both widgets to self.attrs.get('summernote', {})
Owner
|
Thank you for contributing, @cordery ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pop is used to get the value of 'summernote' on self.attrs, then the html returned by render() may change after the first call. For example:
Will render the iframe height as '123px', however a second call
will render whatever the default value for height is instead of '123px' because the summernote value of attrs was popped in the first call and therefore is no longer available for subsequent calls.
This PR fixes that by chaning the self.attrs.pop('summernote', {}) calls in both widgets to self.attrs.get('summernote', {})