Add default fonts and a fix for styling #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqez
changed the title
lqez
force-pushed
the
feature/add-default-font
branch
from
74e4fe6
to
8ccac61
Compare
|
@lqez Thanks for contribution. |
lqez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
* { font-family: blahblah }then it affects the fontname dropdown.Editor.jsto use similar functioneditor.fontStylingto prevent creating empty<span>. Currently, summernote creates an empty<span>with an empty range selection.Where should the reviewer start?
src/js/base/module/Editor.jsHow should this be manually tested?
font-familystyle and click the fontname dropdown.What are the relevant tickets?