Update rendering template to avoid potential XSS attack#21
Open
kacrouse wants to merge 1 commit into
Open
Conversation
Prior to this change, HTML found in the displayed JSON key or value would be rendered. This would allow for a XSS attack if the JSON contained malicious HTML.
LostInBrittany
added a commit
to LostInBrittany/granite-json-tree-viewer
that referenced
this pull request
Jun 6, 2026
Full rewrite of the Polymer 2.x / Bower element as a Lit 3 element: - Vendor summerstyle/jsonTreeViewer as an ES module in src/jsontree.js; the DOM is built with createElement/textContent (no innerHTML), fixing the XSS of summerstyle/jsonTreeViewer#21 for both simple and complex nodes - Replace alert() calls with a jsontree-jsonpath event and a TypeError - Preserve key insertion order by default (opt-in sort-keys attribute) - Replace @apply mixins with CSS custom properties and ::part() - Inline icons.svg as a data URI (no runtime fetching) - npm + @web/dev-server + @web/test-runner tooling, test suite included - Relicense from Apache-2.0 to MIT, matching the vendored library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, HTML found in the displayed JSON key or value would be rendered. This would allow for a XSS attack if the JSON contained malicious HTML.
The fix leverages
textContentto ensure any HTML is properly escaped.