Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Small fixes #361

Merged
merged 5 commits into from Jan 14, 2019
Merged

(docs) Small fixes #361

merged 5 commits into from Jan 14, 2019

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jan 12, 2019

Changes

  • Link to "Development" section in TOC of the readme
  • Fix testing commands in the readme
  • Fix import of globalStyles in font docs
  • Fix email link in the code of conduct
  • Fix grammar

My linter changed the markdown bullet points. 🤷‍♂️

@connor-baer connor-baer added 🛠️ tech Changes to the tech stack or infrastructure ready for review labels Jan 12, 2019
@codecov
Copy link

codecov bot commented Jan 12, 2019

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   68.46%   68.46%           
=======================================
  Files         140      140           
  Lines        2074     2074           
  Branches      337      337           
=======================================
  Hits         1420     1420           
  Misses        535      535           
  Partials      119      119

@sumup-oss sumup-oss deleted a comment from codecov bot Jan 12, 2019
haltsir
haltsir previously approved these changes Jan 14, 2019
Copy link
Contributor

@haltsir haltsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

CODE_OF_CONDUCT.md Show resolved Hide resolved
PUBLISHING.md Outdated Show resolved Hide resolved
Co-Authored-By: connor-baer <connor-baer@users.noreply.github.com>
Copy link
Contributor

@haltsir haltsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add then. :) Looks good!

@connor-baer connor-baer merged commit 130c9e9 into master Jan 14, 2019
@connor-baer connor-baer deleted the docs/fixes branch January 14, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ tech Changes to the tech stack or infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants