Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies to peer dependencies #453

Open
connor-baer opened this issue Jul 26, 2019 · 1 comment

Comments

@connor-baer
Copy link
Member

commented Jul 26, 2019

Suggested change

Main dependencies that are shared between Circuit UI and the application which consumes it should be moved from dependencies to peerDependencies. This has two main benefits:

  • the application can use any compatible version of the package and upgrade at their own pace
  • it prevents those packages from being included in the bundle multiple times

The dependencies I have in mind are react, react-dom, @emotion/core, @emotion/styled, and emotion-theming.

Alternatives

We could keep these packages as dependencies, the downside being the opposite of the benefits described above.

Potential downsides

This should probably be a breaking change.

@connor-baer connor-baer added the tech label Jul 26, 2019
@connor-baer connor-baer added this to the v2.0 milestone Jul 26, 2019
@connor-baer connor-baer added this to To do in v2 via automation Jul 26, 2019
@connor-baer connor-baer referenced this issue Sep 27, 2019
5 of 5 tasks complete
@connor-baer

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

As part of this task, it would be nice to also clean up the dependencies in general. There are a couple of unused dependencies and a bunch of production dependencies that should really be in devDependencies.

@voronianski voronianski moved this from To do to In progress in v2 Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2
  
In progress
2 participants
You can’t perform that action at this time.