extractZIPArchive 存在空循环死代码#47
Merged
Merged
Conversation
added 2 commits
May 13, 2026 18:29
The first for-range loop over reader.File only checked IsDir() and continued without performing any work. Remove this dead code. Closes #8
Prevent CI/tooling directories from being accidentally committed.
|
无遗漏 Issue #8 的需求极其简单:删除 |
|
可合并 审查总结两个变更均干净、安全,无阻塞问题。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
extractZIPArchiveininternal/server/server.gocontained a deadfor range reader.Fileloop (lines 1162–1166) whose body only checkedarchivedFile.FileInfo().IsDir()and issued a barecontinue— it never accumulated state, returned errors, or produced side effects. This was leftover dead code that added unnecessary iteration over every archive entry before the real extraction loop.Approach
Removed the empty loop entirely (5 lines). The real validation and extraction logic in the second
for range reader.Fileloop (archive count check, path normalization, directory creation, file extraction) is untouched and handles all necessary work.Tests
go test ./internal/server/...) coversextractZIPArchiveand continues to pass — behavior is unchanged since the removed loop had no observable effect.Closes #8