New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on deprecated gulp-util #95

Merged
merged 1 commit into from Dec 30, 2017

Conversation

Projects
None yet
4 participants
@ohbarye
Contributor

ohbarye commented Dec 30, 2017

Hello gulp-shell maintainers.

Following gulpjs/gulp-util#143, I dropped dependency on gulp-util.

closes #94

Thanks!

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 30, 2017

Coverage Status

Coverage increased (+0.1%) to 98.0% when pulling b81e940 on ohbarye:remove-gulp-util into bc95669 on sun-zheng-an:master.

coveralls commented Dec 30, 2017

Coverage Status

Coverage increased (+0.1%) to 98.0% when pulling b81e940 on ohbarye:remove-gulp-util into bc95669 on sun-zheng-an:master.

@sun-zheng-an sun-zheng-an merged commit 71f6d26 into sun-zheng-an:master Dec 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sun-zheng-an

This comment has been minimized.

Show comment
Hide comment
@sun-zheng-an

sun-zheng-an Dec 30, 2017

Owner

Thanks!

Owner

sun-zheng-an commented Dec 30, 2017

Thanks!

"lodash.template": "^4.4.0",
"plugin-error": "^0.1.2",
"through2": "^2.0.3",
"vinyl": "^2.1.0"

This comment has been minimized.

@demurgos

demurgos Dec 30, 2017

Vinyl should be in the devDependencies. It is only used for the tests.
Please update it: it is important to avoid unnecessary dependencies.

@demurgos

demurgos Dec 30, 2017

Vinyl should be in the devDependencies. It is only used for the tests.
Please update it: it is important to avoid unnecessary dependencies.

This comment has been minimized.

@ohbarye

ohbarye Dec 30, 2017

Contributor

Oops, that's true. I created another PR for that #96

@ohbarye

ohbarye Dec 30, 2017

Contributor

Oops, that's true. I created another PR for that #96

@demurgos demurgos referenced this pull request Dec 30, 2017

Open

Ecosystem migration #143

94 of 106 tasks complete

@ohbarye ohbarye deleted the ohbarye:remove-gulp-util branch Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment