diff --git a/ChangeLog b/ChangeLog index acd320d69453e6..8359b4e27c2cae 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Sun Jun 15 22:44:25 2008 Yukihiro Matsumoto + + * struct.c (rb_struct_s_def): to_str should be called only once. + [ruby-core:16647] + Sun Jun 15 22:42:54 2008 Yukihiro Matsumoto * ext/zlib/zlib.c (gzreader_gets): may cause infinite loop. diff --git a/struct.c b/struct.c index 88357dedc94d56..994c1e41475a4d 100644 --- a/struct.c +++ b/struct.c @@ -307,19 +307,14 @@ rb_struct_s_def(argc, argv, klass) ID id; rb_scan_args(argc, argv, "1*", &name, &rest); + if (!NIL_P(name) && SYMBOL_P(name)) { + rb_ary_unshift(rest, name); + name = Qnil; + } for (i=0; ilen; i++) { id = rb_to_id(RARRAY(rest)->ptr[i]); RARRAY(rest)->ptr[i] = ID2SYM(id); } - if (!NIL_P(name)) { - VALUE tmp = rb_check_string_type(name); - - if (NIL_P(tmp)) { - id = rb_to_id(name); - rb_ary_unshift(rest, ID2SYM(id)); - name = Qnil; - } - } st = make_struct(name, rest, klass); if (rb_block_given_p()) { rb_mod_module_eval(0, 0, st); diff --git a/version.h b/version.h index aab17a1f86b0e3..effb7c78503680 100644 --- a/version.h +++ b/version.h @@ -2,7 +2,7 @@ #define RUBY_RELEASE_DATE "2008-06-15" #define RUBY_VERSION_CODE 186 #define RUBY_RELEASE_CODE 20080615 -#define RUBY_PATCHLEVEL 203 +#define RUBY_PATCHLEVEL 204 #define RUBY_VERSION_MAJOR 1 #define RUBY_VERSION_MINOR 8