Cyrillic characters in client titles make focus_client_menu and client_invite_menu to fail #44

Closed
edio opened this Issue Mar 21, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@edio
Contributor

edio commented Mar 21, 2012

Steps to reproduce

  1. create client with cyrillic char in title (visit russian page via firefox, for example)
  2. invoke focus_client_menu action and choose client with cyrillic chat in its title to focus

Expected action

  • Tag that contains client becomes selected, client becomes focused

Actual action

  • Nothing happens
@sunaku

This comment has been minimized.

Show comment Hide comment
@sunaku

sunaku Mar 22, 2012

Owner

Since you're able to choose the Cyrillic titled client from the menu, we can narrow down the suspects to the wmiirc logic itself: the Cyrillic text that wimenu emits is probably not in the same encoding as the Cyrillic text that wmiirc supplied it. As a result, the wmiirc is not able to reverse-lookup the index of the chosen item.

Owner

sunaku commented Mar 22, 2012

Since you're able to choose the Cyrillic titled client from the menu, we can narrow down the suspects to the wmiirc logic itself: the Cyrillic text that wimenu emits is probably not in the same encoding as the Cyrillic text that wmiirc supplied it. As a result, the wmiirc is not able to reverse-lookup the index of the chosen item.

@edio

This comment has been minimized.

Show comment Hide comment
@edio

edio Mar 22, 2012

Contributor

Yep, wmiirc logic is a suspect. There is a snippet of code in the control/action/focus.yaml

    focus_client_menu: |
      if client = client_menu('show client:', :client)
        client.focus
      end

I'm not familiar with yaml, but obviously, the problem is in the client_menu() method and value it produces.

Could you please suggest, where to dig for a solution?

Contributor

edio commented Mar 22, 2012

Yep, wmiirc logic is a suspect. There is a snippet of code in the control/action/focus.yaml

    focus_client_menu: |
      if client = client_menu('show client:', :client)
        client.focus
      end

I'm not familiar with yaml, but obviously, the problem is in the client_menu() method and value it produces.

Could you please suggest, where to dig for a solution?

@sunaku

This comment has been minimized.

Show comment Hide comment
@sunaku

sunaku Mar 22, 2012

Owner

Yes, client_menu() is implemented in lib/wmiirc/menu.rb.

Owner

sunaku commented Mar 22, 2012

Yes, client_menu() is implemented in lib/wmiirc/menu.rb.

@sunaku

This comment has been minimized.

Show comment Hide comment
@sunaku

sunaku Sep 24, 2012

Owner

Were you able to fix the problem @edio ?

Owner

sunaku commented Sep 24, 2012

Were you able to fix the problem @edio ?

@edio

This comment has been minimized.

Show comment Hide comment
@edio

edio Sep 24, 2012

Contributor

No, I wasn't, sorry. I tried but gave up quickly.

Contributor

edio commented Sep 24, 2012

No, I wasn't, sorry. I tried but gave up quickly.

@sunaku

This comment has been minimized.

Show comment Hide comment
@sunaku

sunaku Dec 15, 2012

Owner

Closing this issue because your pull request has been merged.

Owner

sunaku commented Dec 15, 2012

Closing this issue because your pull request has been merged.

@sunaku sunaku closed this Dec 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment