feat(framework): add virtual server-entry module to Vite plugin#149
Merged
Conversation
Add resolveId and load hooks so that importing @sundayceo/framework/server-entry resolves to a virtual module that wires createHandler with app, routes, templates, and errorPages. Closes #135 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
CI failed for this pull request. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
CI failed for this pull request. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
CI failed for this pull request. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Closed
qantrepreneur
added a commit
that referenced
this pull request
May 21, 2026
* feat(framework): add virtual server-entry module to Vite plugin Add resolveId and load hooks so that importing @sundayceo/framework/server-entry resolves to a virtual module that wires createHandler with app, routes, templates, and errorPages. Closes #135 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(framework): resolve lint errors in server-entry and vite-plugin test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style(framework): fix prettier formatting in vite-plugin files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(framework): reduce frameworkPlugin line count with arrow functions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Lorenzo <lorenzofkramer@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveIdandloadhooks toframeworkPlugin()so that@sundayceo/framework/server-entryresolves to a virtual module wiringcreateHandlerwith app, routes, templates, and errorPages./server-entrysubpath export inpackage.jsonwith a.d.tsfor TypeScript resolutionCloses #135
Test plan
resolveIdreturns virtual module ID for@sundayceo/framework/server-entryresolveIdreturnsundefinedfor unrelated module IDsloadreturns generated wiring code for the virtual module IDloadreturnsundefinedfor non-virtual module IDs🤖 Generated with Claude Code