feat(framework): slot extraction — Babel AST parser for defineSlots#183
Merged
Conversation
Parse route modules to extract each slot's JSX and dependency closure into standalone virtual module source strings. Supports inline JSX, imported components, block bodies with locals, multi-component trees, and conditional expressions. Closes #171 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove CJS interop dance, non-null assertions, and unnecessary type casts. Use proper Babel types, explicit null coalescing via sliceNode helper, and structured control flow instead of continue statements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Closed
qantrepreneur
added a commit
that referenced
this pull request
May 21, 2026
…183) * feat(framework): slot extraction — Babel AST parser for defineSlots Parse route modules to extract each slot's JSX and dependency closure into standalone virtual module source strings. Supports inline JSX, imported components, block bodies with locals, multi-component trees, and conditional expressions. Closes #171 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor(framework): clean up slot extraction — remove hacks and casts Remove CJS interop dance, non-null assertions, and unnecessary type casts. Use proper Babel types, explicit null coalescing via sliceNode helper, and structured control flow instead of continue statements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Lorenzo <lorenzofkramer@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@babel/parser,@babel/traverse,@babel/generator,@babel/typesas framework depsTest plan
Closes #171
🤖 Generated with Claude Code