feat(framework): add createApp function (#3)#37
Merged
Conversation
Implement the root configuration entry point that accepts context and onError config. The context function's return type propagates through the type system for downstream inference. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
qantrepreneur
force-pushed
the
3-create-app
branch
from
a13be22 to
e671632
Compare
Closed
qantrepreneur
added a commit
that referenced
this pull request
May 21, 2026
Implement the root configuration entry point that accepts context and onError config. The context function's return type propagates through the type system for downstream inference. Co-authored-by: Lorenzo <lorenzofkramer@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createAppfunction that accepts{ context, onError }configurationcontextreceives aRequestand returns user-defined context; the return type is preserved through the generic type parameter for downstream inferenceonErroris optional, receives(error: unknown, request: Request)and returns aResponsecreateAppandAppConfigfrom the package entry pointTest plan
createAppreturns the config object unchanged (identity at runtime)onErrorhandler providedonError(optional)expectTypeOfAppConfiggeneric preserves custom context typepnpm --filter @sundayceo/framework testpasses (14 tests)pnpm --filter @sundayceo/framework check-typespassespnpm lintpassespnpm formatpassesCloses #3
🤖 Generated with Claude Code