Add support for linking with C libraries #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/initialize-c-runtime
branch
4 times, most recently
from
2b96a71
to
8c8d91f
Compare
sunfishcode
force-pushed
the
sunfishcode/initialize-c-runtime
branch
2 times, most recently
from
bf9ecad
to
2433ebe
Compare
sunfishcode
force-pushed
the
sunfishcode/initialize-c-runtime
branch
from
2433ebe
to
f38116c
Compare
|
I think the setjmp/longjmp in this PR will interfere with the one in glibc during libc initialization in some cases: https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/csu/libc-start.c#L291-L309 |
|
Wow, good catch. It's tempting to say that if mustang ever wants to support pthread cancellation, it will need to have complete enough libc emulation that all libc calls made by C libraries are handled, so that it no longer needs initialize-c-runtime at all. |
|
I'm inclined to go with this for now, and we'll see how far it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to initialize the C runtime, so that it's (relatively) safe to call C libraries.
Fixes #2.