Skip to content

expose DirectorySourceOptionsBuilder & added doc example#710

Merged
sunng87 merged 1 commit intosunng87:masterfrom
markwellis:expose_DirectorySourceOptionsBuilder
May 21, 2025
Merged

expose DirectorySourceOptionsBuilder & added doc example#710
sunng87 merged 1 commit intosunng87:masterfrom
markwellis:expose_DirectorySourceOptionsBuilder

Conversation

@markwellis
Copy link
Contributor

DirectorySourceOptions is #[non_exhaustive] which means it cannot be created directly by users of the crate.

DirectorySourceOptions is #[derive(Builder)] but the resulting DirectorySourceOptionsBuilder is not exposed to users of the crate.

Because of this only DirectorySourceOptions::default() can be used and options cannot be set.

Exposing DirectorySourceOptionsBuilder allows users of this crate to build DirectorySourceOptions.

@sunng87
Copy link
Owner

sunng87 commented May 21, 2025

@markwellis That's a good idea. Please check the CI issue and I will merge this once it's fixed. Thank you!

@markwellis markwellis force-pushed the expose_DirectorySourceOptionsBuilder branch from f69d3ff to c94b794 Compare May 21, 2025 07:31
DirectorySourceOptions is `#[non_exhaustive]` which means it cannot be
created directly by users of the crate.

DirectorySourceOptions is `#[derive(Builder)]` but the resulting
DirectorySourceOptionsBuilder is not exposed to users of the crate.

Because of this only `DirectorySourceOptions::default()` can be used and
options cannot be set.

Exposing DirectorySourceOptionsBuilder allows users of this crate to
build DirectorySourceOptions.
@markwellis markwellis force-pushed the expose_DirectorySourceOptionsBuilder branch from c94b794 to 436bf37 Compare May 21, 2025 08:03
@coveralls
Copy link

Coverage Status

coverage: 82.509% (-0.04%) from 82.552%
when pulling 436bf37 on markwellis:expose_DirectorySourceOptionsBuilder
into 4bf34da on sunng87:master.

@sunng87 sunng87 merged commit b76c6a8 into sunng87:master May 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants