New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.8] Backport unit spherical fix (#2463) #2465

Merged
merged 5 commits into from Feb 17, 2018

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

Cadair commented Feb 17, 2018

No description provided.

Cadair added some commits Feb 16, 2018

Fix our handling of "Unit Spherical" where distance is dimensionless
Sometimes when using the SkyCoord constructor the frame will be created with a
SphericalRepresentation with distance=1*u.one rather than an
UnitSphericalRepresentation. This fixes our detection of this case in our frames.

@Cadair Cadair added this to the 0.8.4 milestone Feb 17, 2018

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Feb 17, 2018

Hello @Cadair! Thanks for updating the PR.

Line 71:101: E501 line too long (105 > 100 characters)
Line 74:101: E501 line too long (106 > 100 characters)
Line 170:101: E501 line too long (105 > 100 characters)
Line 176:101: E501 line too long (105 > 100 characters)
Line 242:101: E501 line too long (169 > 100 characters)
Line 246:101: E501 line too long (109 > 100 characters)
Line 249:101: E501 line too long (169 > 100 characters)
Line 301:101: E501 line too long (190 > 100 characters)
Line 306:101: E501 line too long (190 > 100 characters)

Comment last updated on February 17, 2018 at 20:13 Hours UTC

Cadair added some commits Feb 17, 2018

@Cadair Cadair force-pushed the Cadair:0.8_coord_fix branch from ed910c0 to 5fa2048 Feb 17, 2018

@nabobalis nabobalis merged commit 800cc03 into sunpy:0.8 Feb 17, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@Cadair Cadair deleted the Cadair:0.8_coord_fix branch Feb 17, 2018

Cadair added a commit that referenced this pull request Feb 17, 2018

Change the default units for HPC.distance
This is a change needed for #2465 and is one of the changes that was
merged into master in #2431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment