Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the subclasses of Slider and Widget #2613

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

commented May 3, 2018

@nabobalis I heard you like deleting code.

@Cadair Cadair requested a review from DanRyanIrish May 3, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 3, 2018

But why?

@Cadair

This comment has been minimized.

Copy link
Member Author

commented May 3, 2018

because when I wrote this, apparently I didn't know about partial functions.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 3, 2018

I tried to approve via app, it no work

@DanRyanIrish DanRyanIrish merged commit 3723e28 into sunpy:master May 3, 2018

8 of 9 checks passed

codecov/patch 28.57% of diff hit (target 82.02%)
Details
Giles Click details to preview the documentation build
Details
ci/circleci: egg-info-27 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-35 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/project 82.11% (+0.09%) compared to b6830e1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Cadair Cadair deleted the Cadair:visualization_fixes_1 branch May 3, 2018

@Cadair Cadair added this to the 1.0 milestone May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.