Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attrs Registration works #2663

Merged
merged 27 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@nabobalis
Copy link
Contributor

commented Jun 20, 2018

This PR makes that Tab completion works on Attrs provided that a client uses the new method to do so.
In another PR I will update the clients to register values.

This also supersedes PR #2357 and closes #2625.

Current API is shown in the test_attr.py and some details are provided in doc strings.

Todo:

  • Real error handling inside Attr
  • Print(Attr) has to work and return something useful
    screenshot from 2018-06-20 21-44-30
  • More tests
  • Documentation needs a passover and probably more detail.

Only problem with print is really long bits.
screenshot from 2018-06-20 21-47-39

But that can be done in the future.

@sunpy-bot

This comment has been minimized.

Copy link

commented Jun 20, 2018

Thanks for the pull request @nabobalis! Everything looks great!

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 20, 2018

Hello @nabobalis! Thanks for updating the PR.

Comment last updated on October 17, 2018 at 13:32 Hours UTC

@nabobalis nabobalis added this to the 1.0 milestone Jun 20, 2018

@nabobalis nabobalis referenced this pull request Jun 20, 2018

Closed

Extra tests for `net.attrs` #2357

0 of 1 task complete
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/base_client.py Outdated
Show resolved Hide resolved sunpy/net/tests/test_attr.py Outdated
Show resolved Hide resolved sunpy/net/tests/test_attr.py Outdated
Show resolved Hide resolved sunpy/database/attrs.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/base_client.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/__init__.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:meta_net branch 2 times, most recently from bc833cb to 606e7f7 Jun 22, 2018

Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/tests/test_attr.py Outdated
Show resolved Hide resolved changelog/2663.feature.rst Outdated

@nabobalis nabobalis requested a review from dpshelio Jun 25, 2018

Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
@Cadair
Copy link
Member

left a comment

A few more developer API related comments, nothing much.

Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/tests/test_attr.py
Show resolved Hide resolved sunpy/net/tests/test_baseclient.py Outdated
Show resolved Hide resolved sunpy/net/vso/attrs.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:meta_net branch 2 times, most recently from 2dae8cc to 32f81e2 Oct 17, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

Probably needs a rebase for that history.

Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/attr.py Outdated
Show resolved Hide resolved sunpy/net/base_client.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:meta_net branch 2 times, most recently from e39971c to ed9ecc7 Nov 13, 2018

@nabobalis nabobalis force-pushed the nabobalis:meta_net branch 3 times, most recently from 1c23387 to 9f24ca2 Nov 13, 2018

@nabobalis nabobalis force-pushed the nabobalis:meta_net branch from 9f24ca2 to ea1a5bd Nov 13, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented Nov 13, 2018

Test fail is test_download_http which I have fixed in the Rhessi PR.

@nabobalis nabobalis merged commit be77dff into sunpy:master Nov 13, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
sunpy-bot All checks passed
@Cadair

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

🎉 🎉 🎆

@nabobalis nabobalis deleted the nabobalis:meta_net branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.