Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelogs and stuff #2694

Merged
merged 4 commits into from Jul 19, 2018

Conversation

Projects
None yet
4 participants
@vn-ki
Copy link
Member

commented Jul 19, 2018

This PR:

  • changelogs
  • revert circle ci config
  • remove jsoc Time

vn-ki added some commits Jul 19, 2018

Abolish jsoc Time from sunpy land
because he was a clone and clones are illegal.
@pep8speaks

This comment has been minimized.

Copy link

commented Jul 19, 2018

Hello @vn-ki! Thanks for updating the PR.

Line 127:101: E501 line too long (123 > 100 characters)
Line 186:101: E501 line too long (124 > 100 characters)
Line 263:101: E501 line too long (104 > 100 characters)
Line 290:101: E501 line too long (105 > 100 characters)
Line 385:101: E501 line too long (128 > 100 characters)

Comment last updated on July 19, 2018 at 15:28 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Jul 19, 2018

Thanks for the pull request @vn-ki! Everything looks great!

@Cadair

Cadair approved these changes Jul 19, 2018

@Cadair Cadair added this to the Time milestone Jul 19, 2018

@Cadair Cadair merged commit c8b8685 into sunpy:time Jul 19, 2018

8 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 85.77%)
Details
codecov/project Absolute coverage decreased by -1.7% but relative coverage increased by +14.22% compared to aec23ef
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sunpy-bot All checks passed

@vn-ki vn-ki deleted the vn-ki:changelogs-and-stuff branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.