Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all instances of quantity_allclose with u.allclose #2701

Merged
merged 6 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

commented Jul 27, 2018

No description provided.

@Cadair Cadair added this to the 1.0 milestone Jul 27, 2018

@Cadair Cadair requested a review from nabobalis Jul 27, 2018

@pep8speaks

This comment has been minimized.

Copy link

commented Jul 27, 2018

Hello @Cadair! Thanks for updating the PR.

Comment last updated on October 10, 2018 at 19:11 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Jul 27, 2018

Thanks for the pull request @Cadair! Everything looks great!

@sunpy sunpy deleted a comment from sunpy-bot bot Jul 27, 2018

@sunpy sunpy deleted a comment from sunpy-bot bot Jul 27, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2018

grumble, this actually changes the figure tests, as I suspected.

@Cadair Cadair force-pushed the Cadair:pytestimport branch from d09f05d to e08a9cc Oct 10, 2018

Cadair added some commits Jul 27, 2018

@Cadair Cadair force-pushed the Cadair:pytestimport branch from e08a9cc to 88b572c Oct 10, 2018

Cadair added some commits Oct 10, 2018

@nabobalis nabobalis removed the Affects Dev label Oct 12, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2018

I thought I already updated the hashes?

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

Looks like you deleted some by accident

@Cadair Cadair merged commit 435fa24 into sunpy:master Oct 16, 2018

8 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 94.44% of diff hit (target 85.32%)
Details
codecov/project Absolute coverage decreased by -0.39% but relative coverage increased by +9.12% compared to a68a754
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sunpy-bot All checks passed

@Cadair Cadair deleted the Cadair:pytestimport branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.