New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantity_allclose on 0.9 #2702

Merged
merged 3 commits into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

Cadair commented Jul 27, 2018

No description provided.

@Cadair Cadair added this to the 0.9.2 milestone Jul 27, 2018

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jul 27, 2018

Hello @Cadair! Thanks for updating the PR.

Line 84:101: E501 line too long (105 > 100 characters)
Line 87:101: E501 line too long (106 > 100 characters)
Line 189:101: E501 line too long (105 > 100 characters)
Line 195:101: E501 line too long (105 > 100 characters)
Line 203:5: E303 too many blank lines (2)
Line 269:101: E501 line too long (169 > 100 characters)
Line 273:101: E501 line too long (109 > 100 characters)
Line 276:101: E501 line too long (169 > 100 characters)
Line 328:101: E501 line too long (190 > 100 characters)
Line 333:101: E501 line too long (190 > 100 characters)

Line 37:101: E501 line too long (106 > 100 characters)
Line 40:5: E731 do not assign a lambda expression, use a def
Line 238:1: E303 too many blank lines (3)
Line 253:101: E501 line too long (109 > 100 characters)
Line 256:101: E501 line too long (109 > 100 characters)
Line 327:101: E501 line too long (104 > 100 characters)

Comment last updated on July 27, 2018 at 10:01 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

sunpy-bot bot commented Jul 27, 2018

Thanks for the pull request @Cadair!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request, and it is not labelled 'No Changelog Entry Needed'.
    Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

2 similar comments
@sunpy-bot

This comment has been minimized.

Copy link

sunpy-bot bot commented Jul 27, 2018

Thanks for the pull request @Cadair!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request, and it is not labelled 'No Changelog Entry Needed'.
    Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@sunpy-bot

This comment has been minimized.

Copy link

sunpy-bot bot commented Jul 27, 2018

Thanks for the pull request @Cadair!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

  • I didn't detect a changelog file in this pull request, and it is not labelled 'No Changelog Entry Needed'.
    Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

@sunpy-bot

This comment has been minimized.

Copy link

sunpy-bot bot commented Jul 27, 2018

Thanks for the pull request @Cadair! Everything looks great!

1 similar comment
@sunpy-bot

This comment has been minimized.

Copy link

sunpy-bot bot commented Jul 27, 2018

Thanks for the pull request @Cadair! Everything looks great!

Cadair added some commits Jul 27, 2018

update changelog
[ci skip]

@Cadair Cadair merged commit 52f8e93 into sunpy:0.9 Jul 27, 2018

2 of 6 checks passed

ci/circleci: egg-info-35 CircleCI is running your tests
Details
ci/circleci: egg-info-36 CircleCI is running your tests
Details
ci/circleci: html-docs CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: egg-info-27 Your tests passed on CircleCI!
Details
sunpy-bot All checks passed

@Cadair Cadair deleted the Cadair:pytest09 branch Jul 27, 2018

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment