Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused **kwargs and clean timeseries #2717

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
4 participants
@dstansby
Copy link
Contributor

commented Aug 12, 2018

A less complicated redo of my previous PR. Also includes some PEP8 cleaning.

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 12, 2018

Hello @dstansby! Thanks for updating the PR.

Comment last updated on October 15, 2018 at 14:05 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Aug 12, 2018

Thanks for the pull request @dstansby! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Aug 12, 2018

@sunpy-bot

This comment has been minimized.

Copy link

commented Oct 2, 2018

Thanks for the pull request @dstansby! Everything looks great!

@Cadair

Cadair approved these changes Oct 10, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2018

Just a change log and this is good to go. It is technically a breaking change even if it shouldn't break anything.

@nabobalis nabobalis merged commit 93a6eb9 into sunpy:master Oct 15, 2018

4 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
sunpy-bot All checks passed

@dstansby dstansby deleted the dstansby:tseries-clean branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.