Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.matrix() with np.array() #2719

Merged
merged 4 commits into from Aug 14, 2018

Conversation

Projects
None yet
4 participants
@dstansby
Copy link
Contributor

commented Aug 13, 2018

Currently running the doc build results in a lot of the following warning:

/root/project/build/lib.linux-x86_64-3.6/sunpy/map/mapbase.py:704: PendingDeprecationWarning:
the matrix subclass is not the recommended way to represent matrices or deal with linear algebra
(see https://docs.scipy.org/doc/numpy/user/numpy-for-matlab-users.html).
Please adjust your code to use regular ndarray.

This PR swaps out np.matrix() for np.array().

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 13, 2018

Hello @dstansby! Thanks for updating the PR.

Line 147:101: E501 line too long (104 > 100 characters)
Line 790:13: E129 visually indented line with same indent as next logical line
Line 824:101: E501 line too long (101 > 100 characters)
Line 1212:101: E501 line too long (108 > 100 characters)
Line 1213:101: E501 line too long (106 > 100 characters)
Line 1266:101: E501 line too long (103 > 100 characters)
Line 1301:101: E501 line too long (119 > 100 characters)
Line 1370:101: E501 line too long (139 > 100 characters)
Line 1413:101: E501 line too long (128 > 100 characters)
Line 1414:101: E501 line too long (128 > 100 characters)
Line 1455:101: E501 line too long (121 > 100 characters)

Comment last updated on August 14, 2018 at 14:04 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Aug 13, 2018

Thanks for the pull request @dstansby! Everything looks great!

@Cadair

Cadair approved these changes Aug 13, 2018

Copy link
Member

left a comment

lgtm, we really need to fix up the CI don't we.

@Cadair Cadair added this to the 0.9.3 milestone Aug 13, 2018

@Cadair Cadair requested a review from nabobalis Aug 13, 2018

@Cadair

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

@dstansby can you merge master or rebase please? Nabil just fixed up the CI.

@dstansby dstansby force-pushed the dstansby:matrix-2-array branch from 1a5fa4d to 9ee6a52 Aug 14, 2018

@Cadair Cadair merged commit 46a9c6b into sunpy:master Aug 14, 2018

9 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 85.39%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +14.6% compared to 8bdb4e7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed

@dstansby dstansby deleted the dstansby:matrix-2-array branch Aug 14, 2018

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Sep 12, 2018

@nabobalis nabobalis modified the milestones: 0.9.3, 1.0 Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.