Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the example to use the composite maps. #2746

Merged
merged 4 commits into from Jan 23, 2019

Conversation

Projects
None yet
6 participants
@Chicrala
Copy link

commented Sep 11, 2018

Currently it download the HMI files to my directory.
The HMI map will issue the warning for carrington_longitude.

Closes #2741

@pep8speaks

This comment has been minimized.

Copy link

commented Sep 11, 2018

Hello @Chicrala! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 16, 2019 at 21:33 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Sep 11, 2018

Thanks for the pull request @Chicrala! Everything looks great!

@Cadair Cadair added this to the 0.9.4 milestone Sep 12, 2018

@nabobalis nabobalis added the Examples label Oct 2, 2018

@nabobalis

This comment was marked as outdated.

Copy link
Contributor

commented Oct 2, 2018

@Chicrala Thanks for the example! For some reason the build for the example failed. If you look at the html-docs one.

  File "/root/project/examples/maps/composite_map_AIA_HMI.py", line 77, in <module>
    hmi_map = sunpy.map.Map('/Users/andrechicrala/Downloads/testfido/hmi.m_45s.20110607_063300_TAI.2.magnetogram.fits')
ValueError: File not found or invalid input

Looks like you need to change the file path.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2018

Just a heads up, the example PRs generate a lot of interest and comments!

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2018

@Chicrala We just added a sample HMI data file!

@wafels

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

The PR for the HMI FITS file is #2782.

@Chicrala

This comment has been minimized.

Copy link
Author

commented Oct 11, 2018

Ok. I will give a read on these suggestions and re-submit this.
Thanks guys!

@Cadair

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

@Chicrala to update the PR you just push new commits to this branch, it will then update. 😄

@Chicrala

This comment has been minimized.

Copy link
Author

commented Oct 11, 2018

I think I did it right. Can someone have a check?
Then I can see if there are more changes and go over them.

Thanks !=D

@nabobalis nabobalis modified the milestones: 0.9.4, 0.9.5 Nov 6, 2018

Show resolved Hide resolved examples/maps/composite_map_AIA_HMI.py Outdated
Show resolved Hide resolved examples/maps/composite_map_AIA_HMI.py Outdated
Show resolved Hide resolved sunpy/map/cmap_test.py Outdated
Show resolved Hide resolved sunpy/map/cmap_test.py Outdated
Show resolved Hide resolved sunpy/map/cmap_test.py Outdated

@nabobalis nabobalis modified the milestones: 0.9.5, 0.9.6 Nov 23, 2018

@nabobalis nabobalis added this to the 1.0 milestone Jan 9, 2019

@nabobalis nabobalis force-pushed the Chicrala:master branch from e65efed to d3dad44 Jan 9, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

@Chicrala Sorry about this, I just rebased on top of current master and tidied up some of the comments.

The CI is on fire, so the only build we care about is the docs one.

@Chicrala

This comment has been minimized.

Copy link
Author

commented Jan 9, 2019

@nabobalis So I stay put for now waiting for more instructions?

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

@Chicrala No, if you want to make any changes or improvements go ahead.
Since we just merged in another PR, i was planning to rebase this again.

@Chicrala

This comment has been minimized.

Copy link
Author

commented Jan 9, 2019

@nabobalis I can add some operations with maps but I would make a separated tutorial for that and leave those the way they are.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

If you want to add more examples, you can open another pull request for that.

@nabobalis nabobalis added the [Review] label Jan 9, 2019

Show resolved Hide resolved examples/plotting/hmi_LOSmag.py Outdated
Show resolved Hide resolved examples/plotting/hmi_LOSmag.py Outdated

@nabobalis nabobalis force-pushed the Chicrala:master branch from d3dad44 to e034cc6 Jan 9, 2019

sorted now

@nabobalis nabobalis force-pushed the Chicrala:master branch from 207a566 to 12ed60b Jan 11, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

Sorry @Chicrala, it seems that somewhere along the way, the git history got messed up again.

I would suggest that you try to run: git remote update, git reset --hard origin/master to make your local history with the version on GitHub.

@nabobalis nabobalis force-pushed the Chicrala:master branch from 12ed60b to 886afcd Jan 16, 2019

Andre Chicrala and others added some commits Sep 11, 2018

Created the example to use the composite maps.
Currently it download the HMI files to my directory.
The HMI map will issue the warning for carrington_longitude.
Created an example showing how to download and plot data from HMI. In…
… this example it is used the LOS magnetic field branch. This commit address issue #2787.

@nabobalis nabobalis force-pushed the Chicrala:master branch from 886afcd to 16fc5c1 Jan 16, 2019

@nabobalis nabobalis added [Review] and removed [Review] labels Jan 16, 2019

@Cadair

Cadair approved these changes Jan 23, 2019

@Cadair Cadair merged commit b93c7db into sunpy:master Jan 23, 2019

11 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 76f989f...16fc5c1
Details
codecov/project 86.45% remains the same compared to 76f989f
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190116.8 succeeded
Details
@Cadair

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Thanks @Chicrala sorry it so long to get it merged!!

@Chicrala

This comment has been minimized.

Copy link
Author

commented Jan 23, 2019

It was a nice experience! I will keep pushing to learn the mock tests now. I'm struggling a bit with that.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Have a look at #2900, it might offer some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.