Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SunPyDeprecationWarnings into errors when running pytest #2830

Merged
merged 9 commits into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@Cadair
Copy link
Member

commented Nov 1, 2018

This should stop us from raising our own deprecation warnings.

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 1, 2018

Hello @Cadair! Thanks for submitting the PR.

@sunpy-bot

This comment has been minimized.

Copy link

commented Nov 1, 2018

Thanks for the pull request @Cadair! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Nov 1, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

YOU GONNA HATE ME @Cadair

@nabobalis nabobalis force-pushed the Cadair:warnings branch from 21f21b1 to 45bbbb9 Nov 5, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2018

Did you just delete all the code generating the warnings?!

That works for 1.0, but we should really backport this...

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

I also renamed the functions or replaced them where appropriate.

You want this done for 0.9?

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2018

well that turned into one hell of a purge.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

Yeah well the MapCube is probably the bulk of it.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

I can cherry pick the first commit and remove the warnings on 0.9.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

Also xamples/rgb_composite/Ui_RGBComposite.py whatever that all was in the docs folder

Show resolved Hide resolved sunpy/instr/iris/iris.py Outdated
Show resolved Hide resolved sunpy/map/mapsequence.py Outdated

@nabobalis nabobalis force-pushed the Cadair:warnings branch from 8e04f0f to 3e83a46 Nov 7, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

The PR patch does seem to reduce the test coverage.

Cadair and others added some commits Oct 31, 2018

Removed everything dep code and warning.
No more MapCube as well.

@Cadair Cadair force-pushed the Cadair:warnings branch from 555bd01 to 22f4526 Nov 8, 2018

@Cadair Cadair force-pushed the Cadair:warnings branch 2 times, most recently from f077809 to c2d205f Nov 8, 2018

@Cadair Cadair added the [Review] label Nov 8, 2018

@Cadair Cadair force-pushed the Cadair:warnings branch from 2170957 to b9e2f26 Nov 8, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

The majority of the coverage decrease appears to be the fact we are no longer running the deprecated decorator 🤣

@Cadair Cadair requested a review from sunpy/sunpy-maintainers Nov 8, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

nabobalis approved these changes on behalf of sunpy/sunpy-maintainers just now

I CAN DO THAT?

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

APPY DONT LIKE IT

@dpshelio
Copy link
Member

left a comment

a lot of cleanups!! It seems all right.

Show resolved Hide resolved examples/maps/base_and_running_difference_mapcubes.py Outdated
Show resolved Hide resolved examples/maps/base_and_running_difference_mapcubes.py Outdated
Show resolved Hide resolved sunpy/tests/tests/test_self_test.py

@Cadair Cadair force-pushed the Cadair:warnings branch from bdf3a05 to 6018596 Nov 12, 2018

@nabobalis nabobalis merged commit 995ebe4 into sunpy:master Nov 12, 2018

10 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 44.8%)
Details
codecov/project Absolute coverage decreased by -1.36% but relative coverage increased by +5.19% compared to aee7042
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed

@Cadair Cadair deleted the Cadair:warnings branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.