Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning from GenericMap.submap when using pixel Quantities #2833

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
4 participants
@jairideout
Copy link
Contributor

commented Nov 5, 2018

Description

Removes warning from GenericMap.submap when using pixel Quantities as input.

The warning was added in sunpy 0.8.0 to make users aware of the change from range_a/range_b to bottom_left/top_right when using pixel Quantities as input. GenericMap.submap has had this new API in place for awhile now, so it's probably safe to remove the "change in behavior" warning.

Fixes #2578

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 5, 2018

Hello @jairideout! Thanks for submitting the PR.

@sunpy-bot

This comment has been minimized.

Copy link

commented Nov 5, 2018

Thanks for the pull request @jairideout! Everything looks great!

Remove warning from GenericMap.submap when using pixel Quantities
The warning was added in sunpy 0.8.0 to make users aware of the change from `range_a`/`range_b` to `bottom_left`/`top_right` when using pixel `Quantities` as input. `GenericMap.submap` has had this new API in place for awhile now, so it's probably safe to remove the "change in behavior" warning.

Fixes #2578

@jairideout jairideout force-pushed the jairideout:issue-2578 branch from fed3f06 to 065e862 Nov 5, 2018

@nabobalis nabobalis added this to the 1.0 milestone Nov 5, 2018

@Cadair

Cadair approved these changes Nov 5, 2018

@nabobalis nabobalis merged commit bd13405 into sunpy:master Nov 5, 2018

6 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed

@nabobalis nabobalis added the [BugFix] label Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.