Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all __future__ and six imports #2837

Merged
merged 5 commits into from Nov 12, 2018

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

commented Nov 8, 2018

This is based on #2830

@sunpy-bot

This comment has been minimized.

Copy link

commented Nov 8, 2018

Thanks for the pull request @Cadair! Everything looks great!

@sunpy sunpy deleted a comment from pep8speaks Nov 8, 2018

@Cadair Cadair added this to the 1.0 milestone Nov 8, 2018

@Cadair Cadair force-pushed the Cadair:six_and_future branch from fc92d15 to adbe272 Nov 8, 2018

@dpshelio
Copy link
Member

left a comment

Seems ok too

Cadair added some commits Nov 8, 2018

remove all six usage
Also some import sorting because it was fugly

@nabobalis nabobalis force-pushed the Cadair:six_and_future branch from adbe272 to dd81ae7 Nov 12, 2018

nabobalis added some commits Nov 12, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

@nabobalis on you.

@nabobalis nabobalis merged commit 03add11 into sunpy:master Nov 12, 2018

10 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 64.05% of diff hit (target 44.64%)
Details
codecov/project Absolute coverage decreased by -0.86% but relative coverage increased by +19.4% compared to 995ebe4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.