Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox our CI #2839

Merged
merged 2 commits into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@nabobalis
Copy link
Contributor

commented Nov 9, 2018

We now use Tox for run all our CI.

It also allow us to pre-define and generate the same conda environment as the CI locally so we can debug issues this way now.

$ tox -al
py37-offline
py36-offline
py37-online
py37-astropydev
py37-numpydev
py37-build_docs
py36-online
py36-astropydev
py36-numpydev
py36-build_docs
figure

The old ways are still supported. FOR NOW

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 9, 2018

Hello @nabobalis! Thanks for submitting the PR.

@sunpy-bot

This comment has been minimized.

Copy link

commented Nov 9, 2018

Thanks for the pull request @nabobalis! Everything looks great!

@nabobalis nabobalis force-pushed the nabobalis:tox branch from 1759c0d to c629771 Nov 9, 2018

@nabobalis nabobalis added this to the 1.0 milestone Nov 9, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

IT ALL PASSED

@nabobalis nabobalis added the [CodeFix] label Nov 11, 2018

@Cadair

Cadair approved these changes Nov 12, 2018

@Cadair

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

@nabobalis This looks ok to me, but giles and codecov haven't reported on it?

@Cadair

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

Ah I think that's because it has built from your fork. I am going to merge and we can see what the damage is.

@Cadair Cadair merged commit aee7042 into sunpy:master Nov 12, 2018

7 checks passed

ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sunpy-bot All checks passed

@Cadair Cadair deleted the nabobalis:tox branch Nov 12, 2018

@drdavella

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.