Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new example for getting colormaps #2865

Merged
merged 5 commits into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@ehsteve
Copy link
Member

commented Dec 10, 2018

Description

Provide a simple example to get at the SunPy colormaps and using them with matplotlib

@pep8speaks

This comment has been minimized.

Copy link

commented Dec 10, 2018

Hello @ehsteve! Thanks for updating the PR.

Line 25:1: E402 module level import not at top of file

Comment last updated on January 09, 2019 at 11:53 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Dec 10, 2018

Thanks for the pull request @ehsteve! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone Dec 10, 2018

@nabobalis nabobalis added the Examples label Jan 7, 2019

@nabobalis nabobalis force-pushed the ehsteve:cmap_example branch from d1a669c to e48309c Jan 9, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

So I rebased and decided that we also do not need the reference colormap example. I added it to the new example.

Since the CI is on fire, the only build we care about is the docs one.

Looks good to me.
https://5706-2165383-gh.circle-artifacts.com/0/root/project/docs/_build/html/generated/gallery/plotting/sunpy_matplotlib_colormap.html#sphx-glr-generated-gallery-plotting-sunpy-matplotlib-colormap-py

@Cadair

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Can we set the second image (the one with all the colourmaps) as the thumbnail? i.e. https://sphinx-gallery.readthedocs.io/en/latest/auto_examples/plot_choose_thumbnail.html

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

And like magic.

@nabobalis nabobalis force-pushed the ehsteve:cmap_example branch from 5827f40 to 7fad7b3 Jan 9, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Jan 9, 2019

Thanks for the pull request @ehsteve! Everything looks great!

@Cadair

Cadair approved these changes Jan 9, 2019

@Cadair Cadair merged commit 6d0ebdb into sunpy:master Jan 9, 2019

6 of 9 checks passed

ci/circleci: 32bit Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
sunpy.sunpy Build #20190109.12 has failed
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.