Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeep 3: The VSO re-write #2866

Merged
merged 22 commits into from Dec 17, 2018

Conversation

Projects
4 participants
@Cadair
Copy link
Member

commented Dec 12, 2018

This is now working 馃帀

@sunpy-bot

This comment has been minimized.

Copy link

commented Dec 12, 2018

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone Dec 12, 2018

Show resolved Hide resolved docs/conf.py Outdated

@Cadair Cadair force-pushed the Cadair:zeep_3 branch 2 times, most recently from e4f3683 to 4e6f192 Dec 13, 2018

nabobalis and others added some commits Dec 1, 2017

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 4e6f192 to 7876986 Dec 13, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

馃 I think this is close to done. I have rebased to tidy up the history etc.

The only thing I think might fail is database.rst because you know...

@Cadair Cadair requested review from nabobalis and dpshelio Dec 13, 2018

@sunpy sunpy deleted a comment from pep8speaks Dec 13, 2018

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

Stupid question, I assume the time PR won't affect this?

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

I don't think it should

@nabobalis
Copy link
Contributor

left a comment

Looking good to me.

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 5313fe0 to c6a81da Dec 13, 2018

Cadair added some commits Dec 13, 2018

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 976b24d to f9227a2 Dec 13, 2018

@Cadair Cadair added this to Release Blocking Items in SunPy 1.0 Dec 13, 2018

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

So afaict all the fails of the online build are either norh or fermi timeouts, and nothing to do with Zeep.


TIME_FORMAT = config.get("general", "time_format")

DEFAULT_URL_PORT = [{'url': 'http://docs.virtualsolar.org/WSDL/VSOi_rpc_literal.wsdl',
'port': 'nsoVSOi', 'transport': WellBehavedHttpTransport}]
'port': 'nsoVSOi'}]

This comment has been minimized.

Copy link
@sudozer

sudozer Dec 14, 2018

Contributor

I suppose we can add the SDAC wsdl when we get it working w/ zeep. That should require just a few more lines. I think it makes more sense just to fail all the way over to the other wsdl at SDAC instead of failing over to the SDAC port on the NSO wsdl. That makes us more-robust against a cataclysmic failure at NSO.

This comment has been minimized.

Copy link
@Cadair

Cadair Dec 14, 2018

Author Member

yeah, I think we have all the machinery inplace to fail over to whatever wsdl is online. I don't think we test if the things the wsdl uses are online though.

Cadair added some commits Dec 14, 2018

Attempt to allow the online build on travis to fail.
The one on Azure is passing at the moment, so we are going to rely on that for now.

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 6956d96 to 8c4f47a Dec 16, 2018

Show resolved Hide resolved sunpy/net/tests/test_vso.py
Show resolved Hide resolved sunpy/net/vso/vso.py
Show resolved Hide resolved sunpy/net/vso/vso.py
Show resolved Hide resolved sunpy/net/vso/vso.py Outdated

@Cadair Cadair force-pushed the Cadair:zeep_3 branch 2 times, most recently from 2835b62 to 30ad59c Dec 16, 2018

@nabobalis

This comment was marked as resolved.

Copy link
Contributor

commented Dec 16, 2018

What are those last few commits?!

Cadair added some commits Dec 16, 2018

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 155b56c to 5e75302 Dec 17, 2018

@nabobalis nabobalis force-pushed the Cadair:zeep_3 branch from 7779fd5 to f8e1e76 Dec 17, 2018

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 5eb9ea1 to 6b483e3 Dec 17, 2018

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 0a6f7d8 to 83fad48 Dec 17, 2018

@Cadair Cadair force-pushed the Cadair:zeep_3 branch from 83fad48 to 1c43736 Dec 17, 2018

@Cadair Cadair merged commit f0ba7f2 into sunpy:master Dec 17, 2018

11 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
codecov/patch 75.71% of diff hit (target 43.96%)
Details
codecov/project 86.38% (+42.41%) compared to bfc2828
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20181217.8 succeeded
Details

@Cadair Cadair deleted the Cadair:zeep_3 branch Dec 17, 2018

@Cadair Cadair moved this from Release Blocking Items to Finished in SunPy 1.0 Dec 19, 2018

@Cadair Cadair referenced this pull request Dec 19, 2018

Closed

Replace suds-jurko #2089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.