Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked some of the Helioviewer code #2883

Merged
merged 9 commits into from Jan 9, 2019

Conversation

Projects
None yet
3 participants
@nabobalis
Copy link
Contributor

commented Jan 1, 2019

I just tidied up some of the documentation and code for Helioviewer.

I probably should not be adding more png files to the docs.

Todo:

  • Review this not at midnight.
  • Add changelog entry, maybe.
  • Fix those PEP8 issues.

Fixed the 32bit build.
Added pip build and fixed those issues.

@nabobalis nabobalis added the net label Jan 1, 2019

@nabobalis nabobalis added this to the 1.0 milestone Jan 1, 2019

@pep8speaks

This comment was marked as outdated.

Copy link

commented Jan 1, 2019

Hello @nabobalis! Thanks for updating the PR.

Line 66:13: E306 expected 1 blank line before a nested definition, found 0

Line 11:1: E302 expected 2 blank lines, found 1
Line 16:1: E302 expected 2 blank lines, found 1
Line 20:1: E302 expected 2 blank lines, found 1
Line 24:1: E302 expected 2 blank lines, found 1
Line 26:101: E501 line too long (101 > 100 characters)
Line 34:1: E302 expected 2 blank lines, found 1
Line 37:1: E302 expected 2 blank lines, found 1
Line 40:1: E302 expected 2 blank lines, found 1
Line 43:1: E302 expected 2 blank lines, found 1
Line 46:1: E302 expected 2 blank lines, found 1

Line 149:101: E501 line too long (104 > 100 characters)
Line 778:13: E129 visually indented line with same indent as next logical line
Line 786:5: E301 expected 1 blank line, found 0
Line 812:101: E501 line too long (101 > 100 characters)
Line 1184:101: E501 line too long (108 > 100 characters)
Line 1185:101: E501 line too long (106 > 100 characters)
Line 1246:101: E501 line too long (103 > 100 characters)
Line 1277:101: E501 line too long (119 > 100 characters)
Line 1317:62: E252 missing whitespace around parameter equals
Line 1317:63: E252 missing whitespace around parameter equals
Line 1346:101: E501 line too long (139 > 100 characters)
Line 1389:101: E501 line too long (128 > 100 characters)
Line 1390:101: E501 line too long (128 > 100 characters)
Line 1407:55: E252 missing whitespace around parameter equals
Line 1407:56: E252 missing whitespace around parameter equals
Line 1431:101: E501 line too long (121 > 100 characters)

Line 64:101: E501 line too long (113 > 100 characters)
Line 73:101: E501 line too long (124 > 100 characters)
Line 84:101: E501 line too long (124 > 100 characters)
Line 87:101: E501 line too long (130 > 100 characters)
Line 112:101: E501 line too long (114 > 100 characters)
Line 116:101: E501 line too long (105 > 100 characters)

Line 52:101: E501 line too long (101 > 100 characters)
Line 78:101: E501 line too long (117 > 100 characters)
Line 137:101: E501 line too long (106 > 100 characters)
Line 171:101: E501 line too long (121 > 100 characters)
Line 214:101: E501 line too long (112 > 100 characters)
Line 219:101: E501 line too long (109 > 100 characters)

Comment last updated on January 09, 2019 at 12:02 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Jan 1, 2019

Thanks for the pull request @nabobalis! Everything looks great!

Show resolved Hide resolved sunpy/net/helioviewer.py Outdated

@sunpy sunpy deleted a comment from sunpy-bot bot Jan 1, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Jan 1, 2019

@nabobalis nabobalis force-pushed the nabobalis:helio branch 4 times, most recently from a00c063 to 253db70 Jan 2, 2019

Show resolved Hide resolved azure-pipelines.yml Outdated
@nabobalis

This comment was marked as outdated.

Copy link
Contributor Author

commented Jan 3, 2019

@nabobalis nabobalis requested review from wafels and Cadair Jan 3, 2019

Show resolved Hide resolved sunpy/map/sources/soho.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:helio branch 9 times, most recently from 6714f78 to d4966bb Jan 7, 2019

"width": width, "height": height}
else:
adict = {"x1": x1, "x2": x2,
"y1": y1, "y2": y2}

This comment has been minimized.

Copy link
@nabobalis

nabobalis Jan 7, 2019

Author Contributor

This probably needs some sort of check?

@nabobalis nabobalis force-pushed the nabobalis:helio branch from 6fc7f93 to 0744764 Jan 7, 2019

@nabobalis nabobalis added the [Review] label Jan 7, 2019

@nabobalis nabobalis force-pushed the nabobalis:helio branch 3 times, most recently from 8853233 to cdb153d Jan 7, 2019

Show resolved Hide resolved .circleci/config.yml Outdated
Show resolved Hide resolved changelog/2883.breaking.rst Outdated
Show resolved Hide resolved conftest.py
Show resolved Hide resolved docs/guide/acquiring_data/helioviewer.rst
Show resolved Hide resolved docs/guide/acquiring_data/helioviewer.rst Outdated
Show resolved Hide resolved sunpy/net/helioviewer.py Outdated
Show resolved Hide resolved sunpy/net/helioviewer.py Outdated
Show resolved Hide resolved sunpy/net/helioviewer.py Outdated
Show resolved Hide resolved sunpy/net/tests/test_helioviewer.py Outdated
Show resolved Hide resolved sunpy/tests/tests/test_sunpy_data_filenames.py Outdated
Show resolved Hide resolved changelog/2883.breaking.rst Outdated

@nabobalis nabobalis force-pushed the nabobalis:helio branch from b489caa to 04b7a48 Jan 8, 2019

@Cadair

Cadair approved these changes Jan 8, 2019

@nabobalis nabobalis force-pushed the nabobalis:helio branch 2 times, most recently from c8d39f8 to 685ee2b Jan 8, 2019

@nabobalis

This comment was marked as outdated.

Copy link
Contributor Author

commented Jan 9, 2019

CI fail is a fermi 404.

@nabobalis nabobalis force-pushed the nabobalis:helio branch from 685ee2b to 4abdd89 Jan 9, 2019

@Cadair

Cadair approved these changes Jan 9, 2019

@Cadair Cadair merged commit 66520c2 into sunpy:master Jan 9, 2019

11 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip Your tests passed on CircleCI!
Details
codecov/patch 96.87% of diff hit (target 43.34%)
Details
codecov/project 86.42% (+43.07%) compared to 492608d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190109.13 succeeded
Details
@Cadair

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

whoops, forgot to wait for a second review on that, my bad. If anyone has any comments, I will fix them in a separate PR as punishment lol.

@nabobalis nabobalis deleted the nabobalis:helio branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.