Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several DeprecationWarning: invalid escape sequence #2885

Merged
merged 13 commits into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@BoboTiG
Copy link
Contributor

commented Jan 5, 2019

Description

Fixes all DeprecationWarning: invalid escape sequence :)

Fix several DeprecationWarning: invalid escape sequence
Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
@pep8speaks

This comment has been minimized.

Copy link

commented Jan 5, 2019

Hello @BoboTiG! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 05, 2019 at 21:09 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Jan 5, 2019

Thanks for the pull request @BoboTiG! Everything looks great!

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

Do you want me to open a new PR for flake8 fixes? They are not related to my changes but still I can do that work separately :)

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

Hi @BoboTiG , you are referring to the invalid escape sequence in our documentation build?

Also you referring to the pep8 issues that @pep8speaks reported?

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

I was referring to the pep8 issues that @pep8speaks reported. I will open a new PR for those specific fixes.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

I mean't the focus of the changes you've made in this PR?

Also I would be against a separate PR only for pep8 fixes.

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

Oh OK :)

Changes in this PR are related to general Python code, not specifically about what the documentation build reported.
Those DeprecationWarnings are already converted to SyntaxWarnings in the current Python dev branch and will become SyntaxError in a near future version.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2019

If you want to do pep8 fixes, I would suggest doing them in this PR.

Can you check that these errors are gone in the documentation build (ci/circleci: html-docs)?

@nabobalis nabobalis added this to the 1.0 milestone Jan 5, 2019

@nabobalis nabobalis added the [CodeFix] label Jan 5, 2019

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

OK for PEP8 fixes, will do in that PR.

About doc build: the number of such warnings went from 33 to 5. I need to track the last ones.

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

OK, fixed all PEP8 errors. For errors reported from docstrings code, I did not want to break anything so I disabled checks using the noqa comment.

The 5 remaining invalid sequences was inside a .rst file. There is now no more such warning in the documenation build :)

@Cadair

Cadair approved these changes Jan 7, 2019

@nabobalis nabobalis merged commit d717dcc into sunpy:master Jan 7, 2019

8 of 11 checks passed

codecov/patch 66.66% of diff hit (target 85.93%)
Details
codecov/project 74.59% (-11.34%) compared to 87bf0b1
Details
sunpy.sunpy Build #20190106.5 has failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

Thank you very much @BoboTiG!

@BoboTiG BoboTiG deleted the BoboTiG:fix-invalid-seq-warnings branch Jan 7, 2019

@BoboTiG

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.