Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Installing SunPy with pip 19 - Part 2 #2915

Merged
merged 4 commits into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@Cadair
Copy link
Member

commented Jan 28, 2019

No description provided.

Cadair added some commits Jan 28, 2019

include pyproject.toml in sdist
The motivation for this is so that the same pip code paths are used when
installing from a checkout and when installing from an sdist
@sunpy-bot

This comment has been minimized.

Copy link

commented Jan 28, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair requested a review from nabobalis Jan 28, 2019

@Cadair Cadair added this to the 1.0 milestone Jan 28, 2019

Cadair added some commits Jan 28, 2019

Cadair added a commit to Cadair/dkist that referenced this pull request Jan 28, 2019

@nabobalis nabobalis merged commit 5009b08 into sunpy:master Jan 28, 2019

9 of 11 checks passed

codecov/project 75.9% (-10.63%) compared to fdac973
Details
sunpy.sunpy Build #20190128.19 has failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fdac973...a9973b3
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed

@Cadair Cadair deleted the Cadair:fix_pip19_2 branch Jan 28, 2019

Cadair added a commit to Cadair/dkist that referenced this pull request Jan 28, 2019

yashrsharma44 added a commit to yashrsharma44/sunpy that referenced this pull request Feb 3, 2019

Fix Installing SunPy with pip 19 - Part 2 (sunpy#2915)
* Correctly use build isolation in pip 19
* include pyproject.toml in sdist

The motivation for this is so that the same pip code paths are used when
installing from a checkout and when installing from an sdist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.