Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a KCor Map source #2916

Merged
merged 18 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@wafels
Copy link
Member

commented Jan 30, 2019

Description

Supports KCor FITS data in SunPy.

Fixes #1393, and Helioviewer-Project/helioviewer.org#239 .

@sunpy-bot

This comment has been minimized.

Copy link

commented Jan 30, 2019

Thanks for the pull request @wafels! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Jan 30, 2019

@nabobalis nabobalis added the map label Jan 30, 2019

@nabobalis
Copy link
Contributor

left a comment

some really unhelpful comments

Show resolved Hide resolved sunpy/map/sources/mlso.py Outdated
Show resolved Hide resolved sunpy/cm/cm.py
Show resolved Hide resolved sunpy/map/sources/mlso.py Outdated
Show resolved Hide resolved sunpy/map/sources/tests/test_kcor_source.py
Jack Ireland
Show resolved Hide resolved sunpy/map/sources/mlso.py Outdated

Cadair and others added some commits Feb 6, 2019

Update sunpy/map/sources/mlso.py
I accept.

Co-Authored-By: wafels <jackireland@gmail.com>
@wafels

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@wafels

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@Cadair

Cadair approved these changes Feb 7, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Test fail is unrelated and something I will fix again.

@Cadair Cadair merged commit 0378031 into sunpy:master Feb 7, 2019

10 of 11 checks passed

sunpy.sunpy Build #20190206.13 has failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 86.51%)
Details
codecov/project 86.56% (+0.04%) compared to 094c1c1
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
@Cadair

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Thanks @wafels !

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

(Grumbles about the merge in master commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.