Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved to using appdirs for sunpyrc config #2922

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
5 participants
@nabobalis
Copy link
Contributor

commented Feb 1, 2019

Description

Fixes #2869

TODO:

  • Write tests

@nabobalis nabobalis added this to the 1.0 milestone Feb 1, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Feb 1, 2019

Hello @nabobalis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 31:38: E261 at least two spaces before inline comment
Line 33:36: E261 at least two spaces before inline comment
Line 35:10: E261 at least two spaces before inline comment
Line 45:1: E303 too many blank lines (3)
Line 69:101: E501 line too long (107 > 100 characters)
Line 70:101: E501 line too long (122 > 100 characters)
Line 286:101: E501 line too long (116 > 100 characters)
Line 348:101: E501 line too long (106 > 100 characters)
Line 385:101: E501 line too long (115 > 100 characters)
Line 418:13: E128 continuation line under-indented for visual indent
Line 443:30: E128 continuation line under-indented for visual indent
Line 461:1: E265 block comment should start with '# '
Line 469:7: E111 indentation is not a multiple of four
Line 471:7: E111 indentation is not a multiple of four
Line 540:1: E302 expected 2 blank lines, found 1
Line 548:101: E501 line too long (110 > 100 characters)
Line 566:1: E305 expected 2 blank lines after class or function definition, found 1
Line 582:1: E265 block comment should start with '# '

Line 46:101: E501 line too long (101 > 100 characters)

Comment last updated at 2019-03-10 18:52:45 UTC

@sunpy sunpy deleted a comment from sunpy-bot bot Feb 1, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Feb 1, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Feb 1, 2019

@nabobalis nabobalis force-pushed the nabobalis:appdirs branch from a1e9e7d to 6e3c8d3 Feb 1, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Feb 1, 2019

Thanks for the pull request @nabobalis! Everything looks great!

@nabobalis nabobalis force-pushed the nabobalis:appdirs branch from 6e3c8d3 to eee7944 Feb 1, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Feb 1, 2019

Show resolved Hide resolved sunpy/util/config.py
Show resolved Hide resolved sunpy/util/config.py
Show resolved Hide resolved sunpy/util/config.py Outdated
Show resolved Hide resolved sunpy/util/config.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:appdirs branch from eee7944 to da6f9b7 Feb 5, 2019

@nabobalis nabobalis added the [Review] label Feb 23, 2019

@Cadair Cadair force-pushed the nabobalis:appdirs branch from da6f9b7 to 7c54665 Mar 1, 2019

@Cadair

Cadair approved these changes Mar 6, 2019

@nabobalis nabobalis force-pushed the nabobalis:appdirs branch 3 times, most recently from 1a15153 to 0326348 Mar 8, 2019

@nabobalis nabobalis force-pushed the nabobalis:appdirs branch from 0326348 to 5c14889 Mar 10, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

Seems that hec.HECClient() found no servers.

@nabobalis nabobalis merged commit 3d2d62a into sunpy:master Mar 10, 2019

11 of 15 checks passed

codecov/patch 14.19% of diff hit (target 76.17%)
Details
codecov/project 75.48% (-0.7%) compared to df157b4
Details
sunpy.sunpy Build #20190310.17 has test failures
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@nabobalis nabobalis deleted the nabobalis:appdirs branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.