Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Pandas DataFrames in sunpy/sun/models.py to Astropy Tables. #2936

Merged
merged 7 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@AbhigyanBose
Copy link
Contributor

commented Feb 20, 2019

Description

Changed Pandas DataFrames in sunpy/sun/models.py to Astropy Tables.

Fixes #2933

@pep8speaks

This comment has been minimized.

Copy link

commented Feb 20, 2019

Hello @AbhigyanBose! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on March 02, 2019 at 13:56 Hours UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Feb 20, 2019

Thanks for the pull request @AbhigyanBose! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Feb 20, 2019

Show resolved Hide resolved sunpy/sun/models.py Outdated
@nabobalis

This comment was marked as outdated.

Copy link
Contributor

commented Feb 20, 2019

Could you print the new table and show us what it looks like?

@AbhigyanBose

This comment was marked as outdated.

Copy link
Contributor Author

commented Feb 20, 2019

2019-02-21-01 51 15

@AbhigyanBose

This comment was marked as outdated.

Copy link
Contributor Author

commented Feb 20, 2019

2019-02-21-01 56 14

@AbhigyanBose

This comment was marked as outdated.

Copy link
Contributor Author

commented Feb 21, 2019

I made another commit changing Tables to QTable and adding the index.

Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated
@dpshelio
Copy link
Member

left a comment

All very good! There's some indentation that may need to update too.

Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated

@AbhigyanBose AbhigyanBose force-pushed the AbhigyanBose:issue2933 branch from b69fbee to 5805938 Mar 1, 2019

Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated
Show resolved Hide resolved sunpy/sun/models.py Outdated
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

Can you rebase this on top of our current master branch version?
Also can you fix those pep8 issues reported from the bot?

@nabobalis nabobalis changed the title Pandas DataFrames converted to Astropy Tables Issue #2933 Changed Pandas DataFrames in sunpy/sun/models.py to Astropy Tables. Mar 2, 2019

@AbhigyanBose AbhigyanBose force-pushed the AbhigyanBose:issue2933 branch from dd58119 to 8bce32a Mar 2, 2019

@nabobalis nabobalis referenced this pull request Mar 3, 2019

Closed

Update models.py #2949

@nabobalis nabobalis referenced this pull request Mar 4, 2019

Closed

Update models.py #2952

@Cadair

Cadair approved these changes Mar 5, 2019

@nabobalis nabobalis merged commit 9f6ed04 into sunpy:master Mar 5, 2019

14 of 16 checks passed

sunpy.sunpy Build #20190302.2 has failed
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 86.56%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +13.43% compared to 7fcac7f
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Thanks @AbhigyanBose

@AbhigyanBose

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

@nabobalis Welcome. I'm so happy, this was my first contribution to an Open Source project.

yashrsharma44 added a commit to yashrsharma44/sunpy that referenced this pull request Mar 5, 2019

yashrsharma44 added a commit to yashrsharma44/sunpy that referenced this pull request Mar 5, 2019

yashrsharma44 added a commit to yashrsharma44/sunpy that referenced this pull request Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.