Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert_quantity_allclose having pytest dep #2943

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@Cadair
Copy link
Member

commented Feb 27, 2019

This should fix our RTD build. astropy/astropy#8456

@sunpy-bot

This comment has been minimized.

Copy link

commented Feb 27, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair requested a review from nabobalis Feb 27, 2019

@Cadair Cadair added this to the 1.0 milestone Feb 27, 2019

@nabobalis nabobalis merged commit c9310c7 into sunpy:master Feb 27, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 86.56%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +13.43% compared to adb15ea
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190227.8 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:fix_allclose_asdf branch Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.