Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to setuptools_scm #2954

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@nabobalis
Copy link
Contributor

commented Mar 4, 2019

Moved from astropy_helpers ot setuptools_scm for our version number.

@nabobalis nabobalis added this to the 1.0 milestone Mar 4, 2019

@nabobalis nabobalis requested a review from Cadair Mar 4, 2019

@nabobalis nabobalis added the [CodeFix] label Mar 4, 2019

Show resolved Hide resolved pyproject.toml Outdated
Show resolved Hide resolved setup.cfg Outdated
Show resolved Hide resolved setup.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:master branch 2 times, most recently from b91bd7d to e36a2b8 Mar 5, 2019

Show resolved Hide resolved setup.cfg Outdated

@nabobalis nabobalis force-pushed the nabobalis:master branch 5 times, most recently from d852114 to abfdd60 Mar 5, 2019

Show resolved Hide resolved pyproject.toml Outdated

@nabobalis nabobalis force-pushed the nabobalis:master branch from a510436 to 868b5af Mar 5, 2019

Show resolved Hide resolved sunpy/__init__.py Outdated

@nabobalis nabobalis force-pushed the nabobalis:master branch 2 times, most recently from 44f49ba to 716c922 Mar 5, 2019

@nabobalis

This comment was marked as outdated.

Copy link
Contributor Author

commented Mar 5, 2019

CircleCI fails should resolve when this is merged.

@Cadair Cadair force-pushed the nabobalis:master branch from 716c922 to 382ebe7 Mar 5, 2019

@nabobalis nabobalis force-pushed the nabobalis:master branch 8 times, most recently from 9dccdf7 to adc28af Mar 5, 2019

@nabobalis nabobalis force-pushed the nabobalis:master branch from adc28af to 3adc4ee Mar 6, 2019

@Cadair Cadair force-pushed the nabobalis:master branch from da6e717 to 891de94 Mar 6, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Mar 6, 2019

Thanks for the pull request @nabobalis! Everything looks great!

@Cadair

This comment was marked as outdated.

Copy link
Member

commented Mar 6, 2019

Needs a changelog for the numpy version bump.

Show resolved Hide resolved sunpy/version.py

@nabobalis nabobalis force-pushed the nabobalis:master branch from 76ed260 to 7d8c735 Mar 6, 2019

@nabobalis nabobalis force-pushed the nabobalis:master branch from 7d8c735 to 53baa5a Mar 6, 2019

@Cadair

Cadair approved these changes Mar 6, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Online test fail is due to a time out. Should probably refactor that test so it completes after 500 seconds.

@nabobalis nabobalis merged commit 05c92fc into sunpy:master Mar 6, 2019

13 of 15 checks passed

sunpy.sunpy Build #20190306.20 has test failures
Details
sunpy.sunpy (Linux_37_online) Linux_37_online failed
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 598ee15...53baa5a
Details
codecov/project 86.56% (+<.01%) compared to 598ee15
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.