Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made HEC treat start_time and end_time as astropy.time.Time objects #2969

Merged
merged 5 commits into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@AbhigyanBose
Copy link
Contributor

commented Mar 8, 2019

Description

Changed the way time is accessed to pass into TimeQuery() from .isoformat() to .isot.

Fixes #2964

@sunpy-bot

This comment has been minimized.

Copy link

commented Mar 8, 2019

Thanks for the pull request @AbhigyanBose! Everything looks great!

@AbhigyanBose AbhigyanBose changed the title Made HEC treat `start_time` and `end_time` as `astropy.time.Time` objects Made HEC treat start_time and end_time as astropy.time.Time objects Mar 8, 2019

@nabobalis nabobalis added this to the 1.0 milestone Mar 8, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

I think we will want a unittest to go along with this.

@AbhigyanBose

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I'll write the tests and update the pull request.

@pep8speaks

This comment has been minimized.

Copy link

commented Mar 9, 2019

Hello @AbhigyanBose! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-10 04:19:35 UTC
Show resolved Hide resolved changelog/2969.bugfix.rst Outdated

@AbhigyanBose AbhigyanBose force-pushed the AbhigyanBose:issue2964 branch from ce0486e to 6c27c59 Mar 10, 2019

@nabobalis nabobalis merged commit df157b4 into sunpy:master Mar 10, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 76.17%)
Details
codecov/project 76.21% (+0.04%) compared to 76c87eb
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190310.2 has test failures
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Thanks @AbhigyanBose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.