Join GitHub today
Fixing solar rotation for coordinates and the differential rotation of maps #2972
The PR fixes the calculation of the coordinates on the Sun that move due to solar rotation. The main difference is that the motion of the observer must also be taken in to account when calculating the returned coordinate. Note that the current version of SunPy assumes that the observer is always exactly 1 AU away from the Sun, which is incorrect. This is corrected in this PR. The observer is now specified in one of two ways. If a measurement of time is passed in to
The change in API above implied changes to the
Some of the tests rely on AIA maps, which have changed due to Albert’s earlier PR on AIA maps. I will take a look tonight. I hope I just have to recalculate some numbers.…
Sent from my iPhone
On May 19, 2019, at 3:28 PM, Nabil Freij ***@***.***> wrote: The fails are in test_differential_rotate test_rotate_submap_edge and test_calculate_solar_rotate_shift. I assume they are due to changes in the PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.