Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to sample and download data directories #2993

Merged
merged 5 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@Cadair
Copy link
Member

commented Mar 16, 2019

This is a PR in three commits.

The first commit transitions our sample data download to parfive, which required a major refactoring of how the sample data download worked, I also removed support for zip files in the process as we were not using it.

The second commit fixes #2959 by changing the default sample data download location to the platform specific user data directory.

The third commit makes a change to the download dir for all test runs so that all tests which use the default download path download to a tmp dir rather than the actual download dir.

@Cadair Cadair requested review from ehsteve and nabobalis Mar 16, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Mar 16, 2019

Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 67:1: E302 expected 2 blank lines, found 1

Line 47:101: E501 line too long (107 > 100 characters)

Comment last updated at 2019-04-03 16:29:40 UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Mar 16, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair changed the title Improvements to sample data directory Improvements to sample and download data directories Mar 16, 2019

@Cadair Cadair added this to the 1.0 milestone Mar 16, 2019

@Cadair Cadair force-pushed the Cadair:sample_data_dir branch 2 times, most recently from 2c0668d to f3e6e74 Mar 16, 2019

@Cadair Cadair force-pushed the Cadair:sample_data_dir branch from f3e6e74 to ad5a710 Mar 20, 2019

@ehsteve
Copy link
Member

left a comment

Have not tested this on my own computer but have reviewed the code.

Show resolved Hide resolved sunpy/data/sunpyrc
Show resolved Hide resolved sunpy/data/_sample.py
Show resolved Hide resolved sunpy/data/_sample.py
Show resolved Hide resolved changelog/2993.feature.rst

Cadair added some commits Mar 16, 2019

@Cadair Cadair force-pushed the Cadair:sample_data_dir branch from ad5a710 to 74468e9 Mar 25, 2019

@Cadair Cadair requested a review from ehsteve Apr 3, 2019

@ehsteve

ehsteve approved these changes Apr 4, 2019

Copy link
Member

left a comment

Looks good!

@Cadair Cadair merged commit dc0c8cf into sunpy:master Apr 4, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 86.02%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +13.97% compared to 57ad41b
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190403.6 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:sample_data_dir branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.