Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more Python 2 cleanup #2994

Merged
merged 4 commits into from Mar 16, 2019

Conversation

Projects
None yet
2 participants
@Cadair
Copy link
Member

commented Mar 16, 2019

I think this is the last of it, closes #2287

Cadair added some commits Mar 16, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Mar 16, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone Mar 16, 2019

@Cadair Cadair requested a review from nabobalis Mar 16, 2019

@nabobalis nabobalis merged commit dfd2c5a into sunpy:master Mar 16, 2019

15 of 16 checks passed

codecov/patch 80% of diff hit (target 85.82%)
Details
ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/project 85.8% (-0.03%) compared to 0032890
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190316.12 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:cleanup_round4 branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.