sunpy.time python file review #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
Documentation
Cadair
reviewed
Mar 20, 2019
Cadair
reviewed
Mar 20, 2019
nabobalis
removed
Documentation
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Thanks for the pull request @nabobalis! Everything looks great! |
|
I think I am mostly ok with removing those helper functions from time, just make a nice changelog entry with the breaks in. |
Cadair
approved these changes
Apr 17, 2019
Cadair
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time for
sunpy.time.This probably has some controversial changes. Specifically the removal of maybe useful user facing functions?
TODO: