Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunpy.time python file review #2999

Merged
merged 4 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@nabobalis
Copy link
Contributor

commented Mar 17, 2019

Time for sunpy.time.

This probably has some controversial changes. Specifically the removal of maybe useful user facing functions?

TODO:

  • Check radiospectra
Show resolved Hide resolved sunpy/time/timerange.py Outdated
Show resolved Hide resolved sunpy/time/time.py
@sunpy-bot

This comment was marked as off-topic.

Copy link

commented Mar 21, 2019

Thanks for the pull request @nabobalis! Everything looks great!

1 similar comment
@sunpy-bot

This comment has been minimized.

Copy link

commented Mar 21, 2019

Thanks for the pull request @nabobalis! Everything looks great!

@nabobalis nabobalis force-pushed the nabobalis:time branch 3 times, most recently from bd630f1 to 6d3c06c Mar 21, 2019

@Cadair

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

I think I am mostly ok with removing those helper functions from time, just make a nice changelog entry with the breaks in.

@nabobalis nabobalis force-pushed the nabobalis:time branch from 6d3c06c to 976c72a Apr 10, 2019

@nabobalis nabobalis force-pushed the nabobalis:time branch from 976c72a to ffc4372 Apr 10, 2019

Cadair added some commits Apr 17, 2019

@Cadair

Cadair approved these changes Apr 17, 2019

@Cadair

Cadair approved these changes Apr 17, 2019

@Cadair Cadair merged commit 3458afc into sunpy:master Apr 17, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 88.25%)
Details
codecov/project 88.61% (+0.36%) compared to 1700c72
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190417.7 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@nabobalis nabobalis deleted the nabobalis:time branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.