Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image file reviews #3044

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@nabobalis
Copy link
Contributor

commented Apr 13, 2019

Image time.

I did rename sunpy/image/rescale.py → sunpy/image/resample.py and need to add a breaking changelog.

@pep8speaks

This comment has been minimized.

Copy link

commented Apr 13, 2019

Hello @nabobalis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:101: E501 line too long (107 > 100 characters)

Comment last updated at 2019-04-14 13:18:49 UTC
@sunpy-bot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Thanks for the pull request @nabobalis! Everything looks great!

@sunpy sunpy deleted a comment from sunpy-bot bot Apr 13, 2019

@sunpy sunpy deleted a comment from sunpy-bot bot Apr 13, 2019

@nabobalis nabobalis added this to the 1.0 milestone Apr 13, 2019

@nabobalis nabobalis force-pushed the nabobalis:image branch 2 times, most recently from 914496c to 471971a Apr 14, 2019

@nabobalis nabobalis force-pushed the nabobalis:image branch from 471971a to b9a4cec Apr 14, 2019

@nabobalis nabobalis requested a review from Cadair Apr 15, 2019

import pytest
import os

from astropy import units as u

This comment has been minimized.

Copy link
@Cadair

Cadair Apr 15, 2019

Member
Suggested change
from astropy import units as u
import astropy.units as u
@Cadair

Cadair approved these changes Apr 15, 2019

Copy link
Member

left a comment

Needs changelog

@Cadair Cadair merged commit 7d177a6 into sunpy:master Apr 15, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 88.22%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +11.77% compared to ce9f8c4
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190414.10 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@nabobalis nabobalis deleted the nabobalis:image branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.