Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3045 return an empty HEK table #3046

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@samaloney
Copy link
Contributor

commented Apr 15, 2019

Description

Check for an empty query result and if found return empty HEKTable instance and test to cover this case.

Fixes #3045

@sunpy-bot

This comment has been minimized.

Copy link

commented Apr 15, 2019

Thanks for the pull request @samaloney! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Apr 15, 2019

Show resolved Hide resolved sunpy/net/hek/hek.py Outdated
@Cadair

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Thanks @samaloney this looks great.

@Cadair Cadair modified the milestones: 1.0, 0.9.7 Apr 15, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

I will merge this and backport it this evening. Thanks @samaloney

@Cadair

Cadair approved these changes Apr 15, 2019

@Cadair Cadair merged commit d69cf82 into sunpy:master Apr 15, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 88.22%)
Details
codecov/project 88.22% (+<.01%) compared to ce9f8c4
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190415.6 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@nabobalis nabobalis modified the milestones: 0.9.7, 1.0 Apr 15, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

The HEKTable was never backported.

@Cadair Cadair added the Affects Dev label Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.