Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code for wcsaxes #3054

Merged
merged 4 commits into from Apr 18, 2019

Conversation

Projects
2 participants
@Cadair
Copy link
Member

commented Apr 17, 2019

This changes our Map plots to use the defaults in astropy 3.2 which are nicer than ours and means we can remove this code.

closes #2854

@Cadair Cadair added this to the 1.0 milestone Apr 17, 2019

@nabobalis nabobalis added this to High Priority Features in SunPy 1.0 Apr 17, 2019

@nabobalis nabobalis force-pushed the Cadair:wcsaxes_cleanup branch from f018f33 to 4b7b95e Apr 18, 2019

@nabobalis nabobalis force-pushed the Cadair:wcsaxes_cleanup branch from 4b7b95e to d42fdfd Apr 18, 2019

Cadair added some commits Apr 18, 2019

@Cadair Cadair force-pushed the Cadair:wcsaxes_cleanup branch from d42fdfd to 817a944 Apr 18, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Apr 18, 2019

Thanks for the pull request @Cadair! Everything looks great!

@sunpy sunpy deleted a comment from sunpy-bot bot Apr 18, 2019

@Cadair Cadair merged commit c26fa0e into sunpy:master Apr 18, 2019

7 of 9 checks passed

sunpy.sunpy Build #20190418.19 failed
Details
sunpy.sunpy (Linux_37_online) Linux_37_online was canceled
Details
codecov/patch 100% of diff hit (target 88.17%)
Details
codecov/project Absolute coverage decreased by -12.62% but relative coverage increased by +11.82% compared to e214cc4
Details
sunpy-bot All checks passed
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:wcsaxes_cleanup branch Apr 18, 2019

@Cadair Cadair moved this from High Priority Features to Finished in SunPy 1.0 Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.