Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astropy 3.2 test for HGS<>HCRS #3075

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
3 participants
@Cadair
Copy link
Member

commented Apr 26, 2019

Fixes #3066

@Cadair Cadair requested a review from ayshih Apr 26, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented Apr 26, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair added this to the 0.9.7 milestone Apr 26, 2019

@Cadair

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

@Juanlu001 I think this fixes it. I did the imports like this so we can remove the try when we drop 3.1

@Juanlu001
Copy link

left a comment

Excellent!

@ayshih

ayshih approved these changes Apr 26, 2019

Copy link
Contributor

left a comment

Great!

@Cadair Cadair merged commit 7aa5f1d into sunpy:master Apr 26, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b0a1d6c...de8d7dd
Details
codecov/project 88.19% remains the same compared to b0a1d6c
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190426.8 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:astropy_dev_fix branch Apr 26, 2019

ayshih added a commit that referenced this pull request Apr 26, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.