Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basic_plot from Map.peek #3109

Merged
merged 5 commits into from May 20, 2019

Conversation

Projects
3 participants
@Cadair
Copy link
Member

commented May 15, 2019

馃敟 馃敟

@Cadair Cadair requested a review from ehsteve May 15, 2019

@sunpy-bot

This comment has been minimized.

Copy link

commented May 15, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone May 15, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

WE HAD A TEST FOR THIS?

@Cadair

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

oh yeah so we did :/

Cadair added some commits May 15, 2019

@Cadair Cadair force-pushed the Cadair:basic_plot branch from 5c96afc to f6a3dfa May 16, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented May 16, 2019

Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1693:101: E501 line too long (116 > 100 characters)

Comment last updated at 2019-05-17 13:26:30 UTC
Apply suggestions from code review
Co-Authored-By: Nabil Freij <nabil.freij@gmail.com>

@Cadair Cadair requested a review from sunpy/sunpy-maintainers May 17, 2019

@Cadair Cadair added this to Pre-Feature Freeze (2019-05-08) in SunPy 1.0 May 17, 2019

@Cadair Cadair merged commit 75985aa into sunpy:master May 20, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 47.05%)
Details
codecov/project 89.88% (+42.83%) compared to 6bde39b
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190517.3 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details

@Cadair Cadair deleted the Cadair:basic_plot branch May 20, 2019

@Cadair Cadair moved this from Pre-Feature Freeze (2019-05-08) to Finished in SunPy 1.0 May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.