Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliably determine lon/lat from WCS #3116

Merged
merged 3 commits into from May 24, 2019

Conversation

Projects
2 participants
@Cadair
Copy link
Member

commented May 20, 2019

This was a bug found during some NDCube work, so I just copied the lat / lon
extraction out of astropy.

This ensures they are always extracted in the correct order.

@yashrsharma44

@sunpy-bot

This comment has been minimized.

Copy link

commented May 20, 2019

Thanks for the pull request @Cadair! Everything looks great!

@Cadair Cadair modified the milestones: 0.9.10, 0.9.9 May 20, 2019

@Cadair Cadair requested a review from sunpy/sunpy-developers May 20, 2019

@Cadair Cadair added this to Post-Feature Freeze in SunPy 1.0 May 22, 2019

@Cadair Cadair requested a review from nabobalis May 24, 2019

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Azure didnt post?

@Cadair

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Well!

Cadair added some commits May 20, 2019

More reliably determine lon/lat from WCS.
This was a bug found during some NDCube work, so I just copied the lat / lon
extraction out of astropy
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

I can merge and hope?

@Cadair Cadair force-pushed the Cadair:fix_wcs-to-frame branch from cd15b96 to 31119a9 May 24, 2019

@Cadair

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

I rebased and it picked it up.

@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

THE POWER OF THE REBASE

@nabobalis nabobalis merged commit c07a396 into sunpy:master May 24, 2019

16 checks passed

ci/circleci: 32bit Your tests passed on CircleCI!
Details
ci/circleci: egg-info-36 Your tests passed on CircleCI!
Details
ci/circleci: egg-info-37 Your tests passed on CircleCI!
Details
ci/circleci: figure-tests-36 Your tests passed on CircleCI!
Details
ci/circleci: html-docs Your tests passed on CircleCI!
Details
ci/circleci: pip-install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 90.27%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +9.72% compared to f55dae0
Details
giles Click details to preview the documentation build
Details
sunpy-bot All checks passed
sunpy.sunpy Build #20190524.4 succeeded
Details
sunpy.sunpy (Linux_36_Conda_offline) Linux_36_Conda_offline succeeded
Details
sunpy.sunpy (Linux_36_offline) Linux_36_offline succeeded
Details
sunpy.sunpy (Linux_37_online) Linux_37_online succeeded
Details
sunpy.sunpy (Windows_36_offline) Windows_36_offline succeeded
Details
sunpy.sunpy (macOS_37_offline) macOS_37_offline succeeded
Details
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

THANKS

@Cadair Cadair deleted the Cadair:fix_wcs-to-frame branch May 24, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 24, 2019

Merge pull request sunpy#3116 from Cadair/fix_wcs-to-frame
More reliably determine lon/lat from WCS
@nabobalis

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

Backported.

@Cadair Cadair moved this from Post-Feature Freeze to Finished in SunPy 1.0 May 27, 2019

nabobalis added a commit to nabobalis/sunpy that referenced this pull request May 30, 2019

Merge pull request sunpy#3116 from Cadair/fix_wcs-to-frame
More reliably determine lon/lat from WCS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.